1
0
mirror of https://github.com/troisjs/trois.git synced 2024-11-24 04:12:02 +08:00

refactor circle

This commit is contained in:
Kevin Levron 2021-03-15 19:54:33 +01:00
parent 98a8c01ef1
commit 606dcfa9c9
2 changed files with 17 additions and 23 deletions

View File

@ -1,17 +1,23 @@
import { CircleGeometry } from 'three';
import Geometry from './Geometry.js';
export const props = {
radius: { type: Number, default: 1 },
segments: { type: Number, default: 8 },
thetaStart: { type: Number, default: 0 },
thetaLength: { type: Number, default: Math.PI * 2 },
};
export function createGeometry(comp) {
return new CircleGeometry(comp.radius, comp.segments, comp.thetaStart, comp.thetaLength);
};
export default {
extends: Geometry,
props: {
radius: { type: Number, default: 1 },
segments: { type: Number, default: 8 },
thetaStart: { type: Number, default: 0 },
thetaLength: { type: Number, default: Math.PI * 2 },
},
props,
methods: {
createGeometry() {
this.geometry = new CircleGeometry(this.radius, this.segments, this.thetaStart, this.thetaLength);
this.geometry = createGeometry(this);
},
},
};

View File

@ -1,28 +1,16 @@
import { CircleBufferGeometry } from 'three';
import { watch } from 'vue';
import Mesh from './Mesh.js';
import { props, createGeometry } from '../geometries/CircleGeometry.js';
export default {
extends: Mesh,
props: {
radius: { type: Number, default: 1 },
segments: { type: Number, default: 8 },
thetaStart: { type: Number, default: 0 },
thetaLength: { type: Number, default: Math.PI * 2 },
},
props,
created() {
this.createGeometry();
const watchProps = ['radius', 'segments', 'thetaStart', 'thetaLength'];
watchProps.forEach(prop => {
watch(() => this[prop], () => {
this.refreshGeometry();
});
});
this.addGeometryWatchers(props);
},
methods: {
createGeometry() {
this.geometry = new CircleBufferGeometry(this.radius, this.segments, this.thetaStart, this.thetaLength);
this.geometry = createGeometry(this);
},
},
__hmrId: 'Circle',