From fee0fcf9b65101d96941623e01b99884179a6327 Mon Sep 17 00:00:00 2001 From: Ken V Date: Sat, 22 Jan 2022 04:18:40 +0100 Subject: [PATCH 1/2] Add missing SphereGeometry parameters --- src/geometries/SphereGeometry.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/geometries/SphereGeometry.ts b/src/geometries/SphereGeometry.ts index d7ebe58..71a73d5 100644 --- a/src/geometries/SphereGeometry.ts +++ b/src/geometries/SphereGeometry.ts @@ -5,6 +5,10 @@ export const props = { radius: { type: Number, default: 1 }, widthSegments: { type: Number, default: 12 }, heightSegments: { type: Number, default: 12 }, + phiStart: { type: Number, default: 0 }, + phiLength: { type: Number, default: Math.PI * 2 }, + thetaStart: { type: Number, default: 0 }, + thetaLength: { type: Number, default: Math.PI }, } as const export function createGeometry(comp: any): SphereGeometry { From 10b86eff6a0bc38f23a33fefa06c6270890be577 Mon Sep 17 00:00:00 2001 From: Ken V Date: Sat, 22 Jan 2022 05:22:52 +0100 Subject: [PATCH 2/2] Add missing SphereGeometry parameters --- src/geometries/SphereGeometry.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/geometries/SphereGeometry.ts b/src/geometries/SphereGeometry.ts index 71a73d5..c7a2db9 100644 --- a/src/geometries/SphereGeometry.ts +++ b/src/geometries/SphereGeometry.ts @@ -12,7 +12,7 @@ export const props = { } as const export function createGeometry(comp: any): SphereGeometry { - return new SphereGeometry(comp.radius, comp.widthSegments, comp.heightSegments) + return new SphereGeometry(comp.radius, comp.widthSegments, comp.heightSegments, comp.phiStart, comp.phiLength, comp.thetaStart, comp.thetaLength) } export default geometryComponent('SphereGeometry', props, createGeometry)