Work/cordova-plugin-printer
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix code smells

Browse Source
This commit is contained in:
Sebastián Katzer 2016-12-23 18:08:59 +01:00
parent ce5ace90b3
commit 231f9c5dd2
2 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/android/Printer.java
View File

@ -79,7 +79,7 @@ public class Printer extends CordovaPlugin {
/** /**
* Invokes the callback once the job has reached a final state. * Invokes the callback once the job has reached a final state.
*/ */
OnPrintJobStateChangeListener listener = new OnPrintJobStateChangeListener() { private OnPrintJobStateChangeListener listener = new OnPrintJobStateChangeListener() {
/** /**
* Callback notifying that a print job state changed. * Callback notifying that a print job state changed.
* *
@ -278,6 +278,7 @@ public class Printer extends CordovaPlugin {
} }
pm.getInstance().print(docName, adapter, builder.build()); pm.getInstance().print(docName, adapter, builder.build());
view = null;
} }
}); });
} }
@ -299,8 +300,6 @@ public class Printer extends CordovaPlugin {
PluginResult.Status.OK, job.isCompleted()); PluginResult.Status.OK, job.isCompleted());
command.sendPluginResult(res); command.sendPluginResult(res);
view = null;
} }
/** /**

6
src/android/ext/PrinterDiscoverySession.java
View File

@ -72,7 +72,7 @@ public final class PrinterDiscoverySession {
* @param session An instance of type * @param session An instance of type
* android.print.PrinterDiscoverySession * android.print.PrinterDiscoverySession
*/ */
public PrinterDiscoverySession (Object session) { PrinterDiscoverySession(Object session) {
this.session = session; this.session = session;
} }
@ -89,7 +89,7 @@ public final class PrinterDiscoverySession {
/** /**
* Stop discovering printers. * Stop discovering printers.
*/ */
public final void stopPrinterDiscovery() { private void stopPrinterDiscovery() {
Meta.invokeMethod(session, "stopPrinterDiscovery"); Meta.invokeMethod(session, "stopPrinterDiscovery");
} }
@ -151,7 +151,7 @@ public final class PrinterDiscoverySession {
* @return List of their basic infos * @return List of their basic infos
*/ */
@SuppressWarnings("unchecked") @SuppressWarnings("unchecked")
public final List<PrinterInfo> getPrinters() { private List<PrinterInfo> getPrinters() {
Method method = Meta.getMethod(session.getClass(), "getPrinters"); Method method = Meta.getMethod(session.getClass(), "getPrinters");
return (List<PrinterInfo>) Meta.invokeMethod(session, method); return (List<PrinterInfo>) Meta.invokeMethod(session, method);