taolin/eslint-config
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(generic-spacing): improve cases

Browse Source
This commit is contained in:
Anthony Fu 2022-11-02 17:21:24 +08:00
parent e13613fd5f
commit ff6a1fad6a
2 changed files with 25 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/eslint-plugin-antfu/src/rules/generic-spacing.test.ts
View File

@ -13,12 +13,24 @@ type Foo<
`function foo< `function foo<
T T
>() {}`, >() {}`,
'const foo = <T>(name: T) => name',
`interface Log {
foo<T>(name: T): void
}`,
`interface Log {
<T>(name: T): void
}`,
] ]
const invalids = [ const invalids = [
['type Foo<T=true> = T', 'type Foo<T = true> = T'], ['type Foo<T=true> = T', 'type Foo<T = true> = T'],
['type Foo<T,K> = T', 'type Foo<T, K> = T'], ['type Foo<T,K> = T', 'type Foo<T, K> = T'],
['type Foo<T=false,K=1|2> = T', 'type Foo<T = false, K = 1|2> = T', 3], ['type Foo<T=false,K=1|2> = T', 'type Foo<T = false, K = 1|2> = T', 3],
['function foo <T>() {}', 'function foo<T>() {}'], ['function foo <T>() {}', 'function foo<T>() {}'],
[`interface Log {
foo <T>(name: T): void
}`, `interface Log {
foo<T>(name: T): void
}`],
] as const ] as const
it('runs', () => { it('runs', () => {

2
packages/eslint-plugin-antfu/src/rules/generic-spacing.ts
View File

@ -23,6 +23,7 @@ export default createEslintRule<Options, MessageIds>({
const sourceCode = context.getSourceCode() const sourceCode = context.getSourceCode()
return { return {
TSTypeParameterDeclaration: (node) => { TSTypeParameterDeclaration: (node) => {
if (!['TSCallSignatureDeclaration', 'ArrowFunctionExpression'].includes(node.parent.type)) {
const pre = sourceCode.text.slice(0, node.range[0]) const pre = sourceCode.text.slice(0, node.range[0])
const preSpace = pre.match(/(\s+)$/)?.[0] const preSpace = pre.match(/(\s+)$/)?.[0]
// strip space before <T> // strip space before <T>
@ -35,6 +36,7 @@ export default createEslintRule<Options, MessageIds>({
}, },
}) })
} }
}
// add space between <T,K> // add space between <T,K>
const params = node.params const params = node.params