release v0.20.4

README.md

@@ -34,7 +34,8 @@ For example:
 ```json
 {
   "scripts": {
-    "lint": "eslint ."
+    "lint": "eslint .",
+    "lint:fix": "eslint . --fix"
   }
 }
 ```
@@ -54,7 +55,9 @@ Create `.vscode/settings.json`
 
 ## Check Also
 
+- [antfu/dotfiles](https://github.com/antfu/dotfiles) - My dotfiles
 - [antfu/vscode-settings](https://github.com/antfu/vscode-settings) - My VS Code settings
+- [antfu/eslint-config](https://github.com/antfu/eslint-config) - My ESLint config
 - [antfu/ts-starter](https://github.com/antfu/ts-starter) - My starter template for TypeScript library
 - [antfu/vitesse](https://github.com/antfu/vitesse) - My starter template for Vue & Vite app
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@antfu/eslint-config-monorepo",
-  "version": "0.19.4",
+  "version": "0.20.4",
   "private": true,
   "license": "MIT",
   "author": "Anthony Fu <anthonyfu117@hotmail.com> (https://github.com/antfu/)",

packages/all/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@antfu/eslint-config",
-  "version": "0.19.4",
+  "version": "0.20.4",
   "description": "",
   "keywords": [],
   "license": "MIT",

packages/basic/index.js

@@ -135,6 +135,7 @@ module.exports = {
         '@typescript-eslint/no-unused-vars': 'off',
         '@typescript-eslint/no-use-before-define': 'off',
         '@typescript-eslint/no-var-requires': 'off',
+        '@typescript-eslint/comma-dangle': 'off',
         'import/no-unresolved': 'off',
         'no-alert': 'off',
         'no-console': 'off',
@@ -293,5 +294,6 @@ module.exports = {
     // antfu
     'antfu/no-leading-newline': 'error',
     'antfu/if-newline': 'error',
+    // 'antfu/prefer-inline-type-import': 'error',
   },
 }

packages/basic/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@antfu/eslint-config-basic",
-  "version": "0.19.4",
+  "version": "0.20.4",
   "description": "",
   "keywords": [],
   "license": "MIT",

packages/eslint-plugin-antfu/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-antfu",
-  "version": "0.19.4",
+  "version": "0.20.4",
   "license": "MIT",
   "main": "./dist/index.cjs",
   "module": "./dist/index.mjs",

packages/eslint-plugin-antfu/src/index.ts

@@ -1,9 +1,11 @@
 import ifNewline from './rules/if-newline'
 import noLeadingNewline from './rules/no-leading-newline'
+import preferInlineTypeImport from './rules/prefer-inline-type-import'
 
 export default {
   rules: {
     'no-leading-newline': noLeadingNewline,
     'if-newline': ifNewline,
+    'prefer-inline-type-import': preferInlineTypeImport,
   },
 }

packages/eslint-plugin-antfu/src/rules/prefer-inline-type-import.test.ts

@@ -0,0 +1,27 @@
+import { RuleTester } from '@typescript-eslint/utils/dist/ts-eslint'
+import { it } from 'vitest'
+import rule, { RULE_NAME } from './prefer-inline-type-import'
+
+const valids = [
+  'import { type Foo } from \'foo\'',
+  'import type Foo from \'foo\'',
+  'import type * as Foo from \'foo\'',
+]
+const invalids = [
+  ['import type { Foo } from \'foo\'', 'import { type Foo } from \'foo\''],
+]
+
+it('runs', () => {
+  const ruleTester: RuleTester = new RuleTester({
+    parser: require.resolve('@typescript-eslint/parser'),
+  })
+
+  ruleTester.run(RULE_NAME, rule, {
+    valid: valids,
+    invalid: invalids.map(i => ({
+      code: i[0],
+      output: i[1].trim(),
+      errors: [{ messageId: 'preferInlineTypeImport' }],
+    })),
+  })
+})

packages/eslint-plugin-antfu/src/rules/prefer-inline-type-import.ts

@@ -0,0 +1,63 @@
+// Ported from https://github.com/gajus/eslint-plugin-canonical/blob/master/src/rules/preferInlineTypeImport.js
+// by Gajus Kuizinas https://github.com/gajus
+
+import { createEslintRule } from '../utils'
+
+export const RULE_NAME = 'prefer-inline-type-import'
+export type MessageIds = 'preferInlineTypeImport'
+export type Options = []
+
+export default createEslintRule<Options, MessageIds>({
+  name: RULE_NAME,
+  meta: {
+    type: 'suggestion',
+    docs: {
+      description: 'Newline after if',
+      recommended: 'error',
+    },
+    fixable: 'code',
+    schema: [],
+    messages: {
+      preferInlineTypeImport: 'Prefer inline type import',
+    },
+  },
+  defaultOptions: [],
+  create: (context) => {
+    const sourceCode = context.getSourceCode()
+    return {
+      ImportDeclaration: (node) => {
+        // ignore bare type imports
+        if (node.specifiers.length === 1 && ['ImportNamespaceSpecifier', 'ImportDefaultSpecifier'].includes(node.specifiers[0].type))
+          return
+        if (node.importKind === 'type') {
+          context.report({
+            *fix(fixer) {
+              yield * removeTypeSpecifier(fixer, sourceCode, node)
+
+              for (const specifier of node.specifiers)
+                yield fixer.insertTextBefore(specifier, 'type ')
+            },
+            loc: node.loc,
+            messageId: 'preferInlineTypeImport',
+            node,
+          })
+        }
+      },
+    }
+  },
+})
+
+function *removeTypeSpecifier(fixer, sourceCode, node) {
+  const importKeyword = sourceCode.getFirstToken(node)
+
+  const typeIdentifier = sourceCode.getTokenAfter(importKeyword)
+
+  yield fixer.remove(typeIdentifier)
+
+  if (importKeyword.loc.end.column + 1 === typeIdentifier.loc.start.column) {
+    yield fixer.removeRange([
+      importKeyword.range[1],
+      importKeyword.range[1] + 1,
+    ])
+  }
+}

packages/react/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@antfu/eslint-config-react",
-  "version": "0.19.4",
+  "version": "0.20.4",
   "description": "",
   "keywords": [],
   "license": "MIT",

packages/typescript/index.js

@@ -29,7 +29,12 @@ module.exports = {
     // Override JS
     'no-useless-constructor': 'off',
     'indent': 'off',
-    '@typescript-eslint/indent': ['error', 2],
+    '@typescript-eslint/indent': ['error', 2, {
+      ignoredNodes: [
+        'JSXAttribute',
+        'TSTypeParameterInstantiation',
+      ],
+    }],
     'no-unused-vars': 'off',
     '@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_' }],
     'no-redeclare': 'off',

packages/typescript/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@antfu/eslint-config-ts",
-  "version": "0.19.4",
+  "version": "0.20.4",
   "description": "",
   "keywords": [],
   "license": "MIT",

packages/vue/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@antfu/eslint-config-vue",
-  "version": "0.19.4",
+  "version": "0.20.4",
   "description": "",
   "keywords": [],
   "license": "MIT",