chore: release v0.34.0

Closes https://github.com/antfu/eslint-config/issues/112

README.md

@@ -6,8 +6,9 @@
 - Auto fix for formatting (aimed to be used standalone without Prettier)
 - Designed to work with TypeScript, Vue out-of-box
 - Lint also for json, yaml, markdown
-- Sorted imports, dangling commas for cleaner commit diff
+- Sorted imports, dangling commas
 - Reasonable defaults, best practices, only one-line of config
+- **Style principle**: Minimal for reading, stable for diff
 
 ## Usage
 
@@ -54,6 +55,19 @@ Install [VS Code ESLint extension](https://marketplace.visualstudio.com/items?it
 }
 ```
 
+### TypeScript Aware Rules
+
+Type aware rules are enabled when a `tsconfig.eslint.json` is found in the project root. If you want to enable it while have no `tsconfig.eslint.json` in the project root, you can change tsconfig name by modifying `ESLINT_TSCONFIG` env. 
+
+```js
+// .eslintrc.js
+process.env.ESLINT_TSCONFIG = 'tsconfig.json'
+
+module.exports = {
+  extends: '@antfu'
+}
+```
+
 ## Extended Reading
 
 Learn more about the context - [Why I don't use Prettier](https://antfu.me/posts/why-not-prettier).

fixtures/vitesse/package.json

@@ -15,48 +15,48 @@
     "up": "taze major -I"
   },
   "dependencies": {
-    "@unocss/reset": "^0.45.8",
-    "@vueuse/core": "^9.1.0",
-    "@vueuse/head": "^0.7.9",
+    "@unocss/reset": "^0.47.6",
+    "@vueuse/core": "^9.6.0",
+    "@vueuse/head": "^1.0.22",
     "nprogress": "^0.2.0",
-    "pinia": "^2.0.17",
-    "vue": "^3.2.37",
-    "vue-demi": "^0.13.6",
+    "pinia": "^2.0.28",
+    "vue": "^3.2.45",
+    "vue-demi": "^0.13.11",
     "vue-i18n": "^9.2.2",
-    "vue-router": "^4.1.3"
+    "vue-router": "^4.1.6"
   },
   "devDependencies": {
-    "@antfu/eslint-config": "^0.25.2",
-    "@iconify-json/carbon": "^1.1.7",
-    "@intlify/vite-plugin-vue-i18n": "^6.0.0",
+    "@antfu/eslint-config": "^0.33.1",
+    "@iconify-json/carbon": "^1.1.11",
+    "@intlify/vite-plugin-vue-i18n": "^7.0.0",
     "@types/markdown-it-link-attributes": "^3.0.1",
     "@types/nprogress": "^0.2.0",
-    "@vitejs/plugin-vue": "^3.0.1",
-    "@vue/test-utils": "^2.0.2",
+    "@vitejs/plugin-vue": "^4.0.0",
+    "@vue/test-utils": "^2.2.6",
     "critters": "^0.0.16",
     "cross-env": "^7.0.3",
-    "cypress": "^10.4.0",
-    "eslint": "^8.21.0",
+    "cypress": "^12.0.2",
+    "eslint": "^8.29.0",
     "eslint-plugin-cypress": "^2.12.1",
     "https-localhost": "^4.7.1",
-    "markdown-it-link-attributes": "^4.0.0",
-    "markdown-it-shiki": "^0.5.1",
-    "pnpm": "^7.8.0",
-    "shiki": "^0.10.1",
-    "taze": "^0.7.6",
-    "typescript": "^4.7.4",
-    "unocss": "^0.45.5",
-    "unplugin-auto-import": "^0.11.0",
-    "unplugin-vue-components": "^0.22.0",
-    "vite": "^3.0.4",
-    "vite-plugin-inspect": "^0.6.0",
-    "vite-plugin-pages": "^0.25.0",
-    "vite-plugin-pwa": "^0.12.3",
+    "markdown-it-link-attributes": "^4.0.1",
+    "markdown-it-shiki": "^0.7.2",
+    "pnpm": "^7.18.2",
+    "shiki": "^0.11.1",
+    "taze": "^0.8.4",
+    "typescript": "^4.9.4",
+    "unocss": "^0.47.6",
+    "unplugin-auto-import": "^0.12.1",
+    "unplugin-vue-components": "^0.22.12",
+    "vite": "^4.0.0",
+    "vite-plugin-inspect": "^0.7.10",
+    "vite-plugin-pages": "^0.28.0",
+    "vite-plugin-pwa": "^0.14.0",
     "vite-plugin-vue-layouts": "^0.7.0",
-    "vite-plugin-vue-markdown": "^0.21.1",
-    "vite-ssg": "^0.20.2",
-    "vite-ssg-sitemap": "^0.3.1",
-    "vitest": "^0.21.0",
-    "vue-tsc": "^0.39.5"
+    "vite-plugin-vue-markdown": "^0.22.1",
+    "vite-ssg": "^0.22.1",
+    "vite-ssg-sitemap": "^0.4.3",
+    "vitest": "^0.25.7",
+    "vue-tsc": "^1.0.13"
   }
 }

fixtures/vitesse/src/modules/nprogress.ts

@@ -7,6 +7,8 @@ export const install: UserModule = ({ isClient, router }) => {
       if (to.path !== from.path)
         NProgress.start()
     })
-    router.afterEach(() => { NProgress.done() })
+    router.afterEach(() => {
+      NProgress.done()
+    })
   }
 }

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@antfu/eslint-config-monorepo",
-  "version": "0.29.4",
+  "version": "0.34.0",
   "private": true,
   "packageManager": "pnpm@7.1.0",
   "author": "Anthony Fu <anthonyfu117@hotmail.com> (https://github.com/antfu/)",
@@ -14,9 +14,9 @@
   "devDependencies": {
     "@antfu/eslint-config": "*",
     "bumpp": "^8.2.1",
-    "eslint": "^8.23.0",
+    "eslint": "^8.29.0",
     "eslint-plugin-antfu": "workspace:*",
     "rimraf": "^3.0.2",
-    "typescript": "^4.8.2"
+    "typescript": "^4.9.4"
   }
 }

packages/all/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@antfu/eslint-config",
-  "version": "0.29.4",
+  "version": "0.34.0",
   "description": "Anthony's ESLint config",
   "author": "Anthony Fu <anthonyfu117@hotmail.com> (https://github.com/antfu/)",
   "license": "MIT",
@@ -17,21 +17,21 @@
   },
   "dependencies": {
     "@antfu/eslint-config-vue": "workspace:*",
-    "@typescript-eslint/eslint-plugin": "^5.36.1",
-    "@typescript-eslint/parser": "^5.36.1",
+    "@typescript-eslint/eslint-plugin": "^5.46.0",
+    "@typescript-eslint/parser": "^5.46.0",
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-html": "^7.1.0",
     "eslint-plugin-import": "^2.26.0",
-    "eslint-plugin-jsonc": "^2.4.0",
-    "eslint-plugin-n": "^15.2.5",
-    "eslint-plugin-promise": "^6.0.1",
-    "eslint-plugin-unicorn": "^43.0.2",
-    "eslint-plugin-vue": "^9.4.0",
-    "eslint-plugin-yml": "^1.1.0",
+    "eslint-plugin-jsonc": "^2.5.0",
+    "eslint-plugin-n": "^15.6.0",
+    "eslint-plugin-promise": "^6.1.1",
+    "eslint-plugin-unicorn": "^45.0.2",
+    "eslint-plugin-vue": "^9.8.0",
+    "eslint-plugin-yml": "^1.3.0",
     "jsonc-eslint-parser": "^2.1.0",
     "yaml-eslint-parser": "^1.1.0"
   },
   "devDependencies": {
-    "eslint": "^8.23.0"
+    "eslint": "^8.29.0"
   }
 }

packages/basic/index.js

@@ -20,6 +20,7 @@ module.exports = {
     'dist',
     'LICENSE*',
     'output',
+    'out',
     'coverage',
     'public',
     'temp',
@@ -168,6 +169,7 @@ module.exports = {
         '@typescript-eslint/no-use-before-define': 'off',
         '@typescript-eslint/no-var-requires': 'off',
         '@typescript-eslint/comma-dangle': 'off',
+        '@typescript-eslint/consistent-type-imports': 'off',
         'import/no-unresolved': 'off',
         'no-alert': 'off',
         'no-console': 'off',
@@ -223,7 +225,7 @@ module.exports = {
         asyncArrow: 'always',
       },
     ],
-    'no-multiple-empty-lines': ['error', { max: 1, maxBOF: 0, maxEOF: 1 }],
+    'no-multiple-empty-lines': ['error', { max: 1, maxBOF: 0, maxEOF: 0 }],
 
     // es6
     'no-var': 'error',
@@ -285,6 +287,7 @@ module.exports = {
     'require-await': 'off',
     'no-return-assign': 'off',
     'operator-linebreak': ['error', 'before'],
+    'max-statements-per-line': ['error', { max: 1 }],
 
     // unicorns
     // Pass error message when throwing errors

packages/basic/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@antfu/eslint-config-basic",
-  "version": "0.29.4",
+  "version": "0.34.0",
   "description": "",
   "author": "Anthony Fu <anthonyfu117@hotmail.com> (https://github.com/antfu/)",
   "license": "MIT",
@@ -23,17 +23,17 @@
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-html": "^7.1.0",
     "eslint-plugin-import": "^2.26.0",
-    "eslint-plugin-jsonc": "^2.4.0",
+    "eslint-plugin-jsonc": "^2.5.0",
     "eslint-plugin-markdown": "^3.0.0",
-    "eslint-plugin-n": "^15.2.5",
+    "eslint-plugin-n": "^15.6.0",
     "eslint-plugin-no-only-tests": "^3.1.0",
-    "eslint-plugin-promise": "^6.0.1",
-    "eslint-plugin-unicorn": "^43.0.2",
-    "eslint-plugin-yml": "^1.1.0",
+    "eslint-plugin-promise": "^6.1.1",
+    "eslint-plugin-unicorn": "^45.0.2",
+    "eslint-plugin-yml": "^1.3.0",
     "jsonc-eslint-parser": "^2.1.0",
     "yaml-eslint-parser": "^1.1.0"
   },
   "devDependencies": {
-    "eslint": "^8.23.0"
+    "eslint": "^8.29.0"
   }
 }

packages/eslint-plugin-antfu/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-antfu",
-  "version": "0.29.4",
+  "version": "0.34.0",
   "license": "MIT",
   "homepage": "https://github.com/antfu/eslint-config",
   "main": "./dist/index.cjs",
@@ -16,11 +16,11 @@
     "prepublishOnly": "nr build"
   },
   "dependencies": {
-    "@typescript-eslint/utils": "^5.36.1"
+    "@typescript-eslint/utils": "^5.46.0"
   },
   "devDependencies": {
-    "@types/node": "^18.11.8",
-    "unbuild": "^0.8.10",
-    "vitest": "^0.22.1"
+    "@types/node": "^18.11.13",
+    "unbuild": "^1.0.2",
+    "vitest": "^0.25.7"
   }
 }

packages/eslint-plugin-antfu/src/rules/prefer-inline-type-import.ts

@@ -1,6 +1,7 @@
 // Ported from https://github.com/gajus/eslint-plugin-canonical/blob/master/src/rules/preferInlineTypeImport.js
 // by Gajus Kuizinas https://github.com/gajus
-
+import type { TSESTree } from '@typescript-eslint/utils'
+import type { RuleFixer, SourceCode } from '@typescript-eslint/utils/dist/ts-eslint'
 import { createEslintRule } from '../utils'
 
 export const RULE_NAME = 'prefer-inline-type-import'
@@ -47,7 +48,7 @@ export default createEslintRule<Options, MessageIds>({
   },
 })
 
-function *removeTypeSpecifier(fixer, sourceCode, node) {
+function * removeTypeSpecifier(fixer: RuleFixer, sourceCode: Readonly<SourceCode>, node: TSESTree.ImportDeclaration) {
   const importKeyword = sourceCode.getFirstToken(node)
 
   const typeIdentifier = sourceCode.getTokenAfter(importKeyword)

packages/react/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@antfu/eslint-config-react",
-  "version": "0.29.4",
+  "version": "0.34.0",
   "description": "",
   "author": "Anthony Fu <anthonyfu117@hotmail.com> (https://github.com/antfu/)",
   "license": "MIT",
@@ -20,12 +20,12 @@
   },
   "dependencies": {
     "@antfu/eslint-config-ts": "workspace:*",
-    "eslint-plugin-react": "^7.31.1",
+    "eslint-plugin-react": "^7.31.11",
     "eslint-plugin-react-hooks": "^4.6.0"
   },
   "devDependencies": {
-    "eslint": "^8.23.0",
+    "eslint": "^8.29.0",
     "react": "^18.2.0",
-    "typescript": "^4.8.2"
+    "typescript": "^4.9.4"
   }
 }

packages/typescript/index.js

@@ -1,5 +1,9 @@
+const fs = require('fs')
+const { join } = require('path')
 const basic = require('@antfu/eslint-config-basic')
 
+const tsconfig = process.env.ESLINT_TSCONFIG || 'tsconfig.eslint.json'
+
 module.exports = {
   extends: [
     '@antfu/eslint-config-basic',
@@ -11,7 +15,44 @@ module.exports = {
       node: { extensions: ['.js', '.jsx', '.mjs', '.ts', '.tsx', '.d.ts'] },
     },
   },
-  overrides: basic.overrides,
+  overrides: basic.overrides.concat(
+    !fs.existsSync(join(process.cwd(), tsconfig))
+      ? []
+      : [{
+          parserOptions: {
+            tsconfigRootDir: process.cwd(),
+            project: [tsconfig],
+          },
+          parser: '@typescript-eslint/parser',
+          excludedFiles: ['**/*.md/*.*'],
+          files: ['*.ts', '*.tsx', '*.mts', '*.cts'],
+          // https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/configs/recommended-requiring-type-checking.ts
+          rules: {
+            'no-throw-literal': 'off',
+            '@typescript-eslint/no-throw-literal': 'error',
+            'no-implied-eval': 'off',
+            '@typescript-eslint/no-implied-eval': 'error',
+            'dot-notation': 'off',
+            '@typescript-eslint/dot-notation': ['error', { allowKeywords: true }],
+            'no-void': ['error', { allowAsStatement: true }],
+            '@typescript-eslint/no-floating-promises': 'error',
+            '@typescript-eslint/no-misused-promises': 'error',
+            '@typescript-eslint/await-thenable': 'error',
+            '@typescript-eslint/no-for-in-array': 'error',
+            '@typescript-eslint/no-unnecessary-type-assertion': 'error',
+            '@typescript-eslint/no-unsafe-argument': 'error',
+            '@typescript-eslint/no-unsafe-assignment': 'error',
+            '@typescript-eslint/no-unsafe-call': 'error',
+            '@typescript-eslint/no-unsafe-member-access': 'error',
+            '@typescript-eslint/no-unsafe-return': 'error',
+            'require-await': 'off',
+            '@typescript-eslint/require-await': 'error',
+            '@typescript-eslint/restrict-plus-operands': 'error',
+            '@typescript-eslint/restrict-template-expressions': 'error',
+            '@typescript-eslint/unbound-method': 'error',
+          },
+        }],
+  ),
   rules: {
     'import/named': 'off',
 
@@ -109,17 +150,6 @@ module.exports = {
     // antfu
     'antfu/generic-spacing': 'error',
 
-    // The following rule overrides require a parser service, aka. require a `typescript.json` path.
-    // This needs to be done individually for each project, and it slows down linting significantly.
-    // 'no-throw-literal': 'off',
-    // '@typescript-eslint/no-throw-literal': 'error',
-    // 'no-implied-eval': 'off',
-    // '@typescript-eslint/no-implied-eval': 'error',
-    // 'dot-notation': 'off',
-    // '@typescript-eslint/dot-notation': ['error', { allowKeywords: true }],
-    // '@typescript-eslint/no-floating-promises': 'error',
-    // '@typescript-eslint/no-misused-promises': 'error',
-
     // off
     '@typescript-eslint/consistent-indexed-object-style': 'off',
     '@typescript-eslint/naming-convention': 'off',

packages/typescript/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@antfu/eslint-config-ts",
-  "version": "0.29.4",
+  "version": "0.34.0",
   "description": "",
   "author": "Anthony Fu <anthonyfu117@hotmail.com> (https://github.com/antfu/)",
   "license": "MIT",
@@ -18,10 +18,10 @@
   },
   "dependencies": {
     "@antfu/eslint-config-basic": "workspace:*",
-    "@typescript-eslint/eslint-plugin": "^5.36.1",
-    "@typescript-eslint/parser": "^5.36.1"
+    "@typescript-eslint/eslint-plugin": "^5.46.0",
+    "@typescript-eslint/parser": "^5.46.0"
   },
   "devDependencies": {
-    "eslint": "^8.23.0"
+    "eslint": "^8.29.0"
   }
 }

packages/vue/index.js

@@ -1,3 +1,10 @@
+const { isPackageExists } = require('local-pkg')
+
+const TS = isPackageExists('typescript')
+
+if (!TS)
+  console.warn('[@antfu/eslint-config] TypeScript is not installed, fallback to JS only.')
+
 module.exports = {
   overrides: [
     {
@@ -9,13 +16,17 @@ module.exports = {
       rules: {
         'no-unused-vars': 'off',
         'no-undef': 'off',
-        '@typescript-eslint/no-unused-vars': 'off',
+        ...(TS
+          ? { '@typescript-eslint/no-unused-vars': 'off' }
+          : null),
       },
     },
   ],
   extends: [
     'plugin:vue/vue3-recommended',
-    '@antfu/eslint-config-ts',
+    TS
+      ? '@antfu/eslint-config-ts'
+      : '@antfu/eslint-config-basic',
   ],
   rules: {
     'vue/max-attributes-per-line': 'off',

packages/vue/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@antfu/eslint-config-vue",
-  "version": "0.29.4",
+  "version": "0.34.0",
   "description": "",
   "author": "Anthony Fu <anthonyfu117@hotmail.com> (https://github.com/antfu/)",
   "license": "MIT",
@@ -15,10 +15,12 @@
     "eslint": ">=7.4.0"
   },
   "dependencies": {
+    "@antfu/eslint-config-basic": "workspace:*",
     "@antfu/eslint-config-ts": "workspace:*",
-    "eslint-plugin-vue": "^9.4.0"
+    "eslint-plugin-vue": "^9.8.0",
+    "local-pkg": "^0.4.2"
   },
   "devDependencies": {
-    "eslint": "^8.23.0"
+    "eslint": "^8.29.0"
   }
 }